Fix trial rebuilds #239
Merged
Fix trial rebuilds #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tsibley flagged internally¹ that a trial build for mpxv² did not work as expected. The trial build did not work for a couple reasons: 1. the `TRIAL_NAME` envvar was not ported over to be provided as an env input when we switched to the pathogen-repo-build workflow³ 2. the default deploy_url was updated to "s3://nextstrain-data" in the nextstrain_automation.yaml⁴ but was not configured for the trial builds This commit fixes both by creating a separate job to configure the config overrides needed for trial builds. ¹ https://bedfordlab.slack.com/archives/C03J4JG4ZE0/p1707781980142229?thread_ts=1707780683.405599&cid=C03J4JG4ZE0 ² https://github.com/nextstrain/mpox/actions/runs/7879309419 ³ 7e5cc67 ⁴ 4017f51
Instead of mixing in trial builds Slack messages with the automated builds, send the Slack messages to the `TEST_SLACK_CHANNEL` set in the repo's action variables¹ (currently the #scratch channel). ¹ https://github.com/nextstrain/mpox/settings/variables/actions
|
Going to merge this pre-review since test trial builds all worked as expected. I will be using them for #238. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fix trial rebuilds for phylogenetic workflows by setting config overrides and sending trial build messages to the testing Slack channel (#scratch).
Related issue(s)
Follow up to
Checklist